"Random Config Provider" node sometimes selects a "PropTraffic" vehicle configuration

Hash · Dec 17, 2022

Bug:

The "Random Config Provider" node selects a "PropTraffic" configuration 4.10% of the time it executes.

Steps to reproduce bug:

Run the attached example flowgraph

Observe that the values printed in the console approach 4.10

or

Create a "Random Config Provider" node and connect the flow input pin

Run the flowgraph

Observe that the "config" output pin of the node sometimes starts with "simple_traffic_"

Notes:

I guess this one might be considered "working as intended", but I imagine that for most mod developers this will only cause unexpected bugs.

Another thing to consider might be the "Use simplified vehicles" gameplay setting.
Currently the node doesn't seem to check this setting while filtering out vehicles.
While it would be possible to handle it automatically, I think it would be best to add a "allowSimpleVehicles" input pin or something similar.

I have attached a modified version of the node which I believe behaves in a more straightforward way.
It should be compatible with flowgraphs created with the current node.

TStabbert · Dec 19, 2022

Hey! Thanks for the info

The randomConfigProvider node is indeed a bit outdated - iirc it was made before we added the parked and simpletraffic to the game.

It was originally used in the Garage2Garage scenario, but when we changed it into a missionType, we moved the vehicle pool generation logic out of the node for performance and easier access. If you're interested, you can find the new code in gameplay/missionTypes/garageToGarage/constructor.lua:selectVehicle().

One issue i see with your code is that the vehicle options are generated in _executionStarted(), but it does use pinIn-values. This means the values cannot be driven by other nodes, only by hardcoded pins. One option to fix that would be to store the generation-settings when generating. In work(), you can then regenerate the options if there are no options, or if the current options are different from the stored options.

Hash · Dec 20, 2022

Good catch! Thanks for checking my code.
I will take a look at the new code and see if I want to steal some functions out of it (muahaha)
I appreciate the support you give to modders

Forums

Mods

"Random Config Provider" node sometimes selects a "PropTraffic" vehicle configuration

Hash
Expand Collapse

Attached Files:

TStabbert
Expand Collapse

BeamNG Team

Hash
Expand Collapse

Useful Searches

"Random Config Provider" node sometimes selects a "PropTraffic" vehicle configuration

Hash Expand Collapse

Attached Files:

TStabbert Expand Collapse BeamNG Team

Hash Expand Collapse

Hash
Expand Collapse

TStabbert
Expand Collapse

BeamNG Team

Hash
Expand Collapse