Powertrain device discovery bug

I discovered a bug in the powertrain initialization function that manifests itself when a vehicle containing custom powertrain devices is the first vehicle loaded. I found the bug when loading the "Hustle and Bustle" campaign, which loads up the citybus immediately. It was giving an error in the console about not being able to find the "automaticGearbox" powertrain device type, when the file was definitely present.

I did some debugging and pinpointed the source of the bug to line 279 of powertrain.lua:

Code:

local files = tableMerge(globalFiles, vehicleFiles)

Because it's doing a table merge, any files found in vehicleFiles will overwrite the first n files in globalFiles. My custom "ecvtGearbox", loaded from the citybus folder, was in index "1" of vehicleFiles, which then overwrote index "1" of globalFiles (automaticGearbox). The line should read:

Code:

local files = arrayConcat(globalFiles, vehicleFiles)

Applying this fix to my local scripts fixed the bug for me.

 

Excellent, glad my code skills could be of help! I've been digging into the game files to learn more about the game engine for writing mods, and I have to say, the code is very well organized! Made it pretty straightforward to locate the problem once I dug deep enough